-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump logs for the deepgram issue detection #910
Conversation
WalkthroughThe changes introduced in this commit primarily focus on enhancing the debugging process for the Changes
Uplevel your code reviews with Entelligence.AI ProEntelligence.AI ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, Entelligence.AI Pro is free for open source projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files selected (1)
- backend/routers/transcribe.py (3)
Review comments generated (3)
- Review: 3
- LGTM: 0
Tips
Chat with Entelligence.AI Bot (@Entelligence.AI
)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@Entelligence.AI
in a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@Entelligence.AI: ignore
anywhere in the PR description to pause further reviews from the bot.
@@ -205,6 +205,7 @@ def stream_audio(audio_buffer): | |||
file_path, duration = None, 0 | |||
if language == 'en' and (codec == 'opus' or codec == 'pcm16') and include_speech_profile: | |||
file_path = get_profile_audio_if_exists(uid) | |||
print(f'deepgram-obns3: file_path {file_path}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's understandable that you're adding print statements for debugging purposes, it's not a good practice to leave them in the production code. Instead, consider using a logging library which can be configured to output logs at different levels (DEBUG, INFO, WARNING, ERROR, CRITICAL). This way, you can set the level of logging at runtime without having to modify your code.
- print(f'deepgram-obns3: file_path {file_path}')
+ import logging
+ logging.debug(f'deepgram-obns3: file_path {file_path}')
@@ -219,6 +220,7 @@ def stream_audio(audio_buffer): | |||
stream_transcript, speech_profile_stream_id, language, sample_rate, deepgram_codec_value, channels | |||
) | |||
|
|||
print(f'deepgram-obns3: send_initial_file_path > deepgram_socket {deepgram_socket}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print(f'deepgram-obns3: receive_audio > dg_socket1 {dg_socket1}') | ||
print(f'deepgram-obns3: receive_audio > dg_socket2 {dg_socket2}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, replace the print statements with debug log statements.
- print(f'deepgram-obns3: receive_audio > dg_socket1 {dg_socket1}')
- print(f'deepgram-obns3: receive_audio > dg_socket2 {dg_socket2}')
+ logging.debug(f'deepgram-obns3: receive_audio > dg_socket1 {dg_socket1}')
+ logging.debug(f'deepgram-obns3: receive_audio > dg_socket2 {dg_socket2}')
Remember to configure the logging level appropriately in your application's configuration or main function.
Summary by Entelligence.AI
stream_audio
andreceive_audio
functions intranscribe.py
. This will improve our ability to troubleshoot issues and ensure a smoother user experience with audio streaming and receiving.